[iQue] Match z_message #2435
Merged
[iQue] Match z_message #2435
+335
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngheloAlf
reviewed
Jan 20, 2025
|
The new PRINTFs are in NTSC-only code, so they wouldn't show up in the debug ROM. When matching NTSC we didn't bother to guess what they were (and some of them ended up being subtly different from PAL anyway) |
AngheloAlf
approved these changes
Jan 20, 2025
fig02
reviewed
Jan 20, 2025
fig02
approved these changes
Jan 20, 2025
|
we could also write |
|
Here's how that would look: cadmic@2d9686d |
|
I like it alot more, but would understand if others are hesitant |
|
I think I like it better too so I made the change |
|
@AngheloAlf pinging incase you want to re-review with the new change |
AngheloAlf
approved these changes
Jan 21, 2025
Thar0
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big clue was that the debug string
was changed to
so I think they did a find-and-replace everywhere to workaround the EGCS bug. I made macros for
msgCtx->msgBufDecoded,msgCtx->msgBufDecodedWide,font->msgBuf, andfont->msgBufWidewhich are kind of annoying to read but maybe not terrible